Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(common): Use Nullish coalescing assignment when possible. #53931

Closed
wants to merge 1 commit into from
Closed

refactor(common): Use Nullish coalescing assignment when possible. #53931

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Inspired by #53923, lets simplify code when possible.

@JeanMeche JeanMeche marked this pull request as ready for review January 15, 2024 21:28
@JeanMeche JeanMeche force-pushed the common/assignment branch 3 times, most recently from 27c5c4f to ac38c30 Compare January 16, 2024 14:49
dgp1130
dgp1130 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for: fw-i18n

packages/common/src/location/hash_location_strategy.ts Outdated Show resolved Hide resolved
@dylhunn dylhunn self-requested a review January 17, 2024 17:09
@dylhunn dylhunn added the area: common Issues related to APIs in the @angular/common package label Jan 17, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 17, 2024
@JeanMeche JeanMeche force-pushed the common/assignment branch 2 times, most recently from aa80b62 to 2b06cec Compare January 17, 2024 18:58
@jessicajaniuk jessicajaniuk removed the request for review from pkozlowski-opensource January 26, 2024 16:23
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 26, 2024
jessicajaniuk pushed a commit that referenced this pull request Jan 26, 2024
@JeanMeche @thePunderWoman
refactor(common): Use Nullish coalescing assignment when possible. (#…
8109013 
…53931)

Inspired by #53923, lets simplify code when possible.

PR Close #53931
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 89ab1c1.

nikvarma pushed a commit to nikvarma/angular that referenced this pull request Jan 31, 2024
@JeanMeche @nikvarma
refactor(common): Use Nullish coalescing assignment when possible. (a…
1a778fb 
…ngular#53931)

Inspired by angular#53923, lets simplify code when possible.

PR Close angular#53931
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 26, 2024
@JeanMeche JeanMeche deleted the common/assignment branch February 29, 2024 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 left review comments

@garrettld garrettld garrettld left review comments

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

@dgp1130 dgp1130 dgp1130 approved these changes

@dylhunn dylhunn dylhunn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
6 participants
@JeanMeche @jessicajaniuk @dylhunn @dgp1130 @garrettld @alan-agius4