Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove remaining internal methods/constructors #50893

Closed
wants to merge 2 commits into from
Closed

docs: remove remaining internal methods/constructors #50893

wants to merge 2 commits into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Jun 29, 2023 •
edited
Loading

JeanMeche added 2 commits June 29, 2023 18:59
@JeanMeche
refactor(animations): Fix JSDoc comment
610a7e5 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.
@JeanMeche
refactor(platform-browser-dynamic): Fix JSDoc comment
4d90067 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.
@pullapprove pullapprove bot requested a review from jessicajaniuk June 29, 2023 17:03
@ngbot ngbot bot modified the milestone: Backlog Jun 29, 2023
@github-actions
Copy link

Deployed aio for 4d90067 to: https://ng-dev-previews-fw--pr-angular-angular-50893-tvrljh0x.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

jessicajaniuk
jessicajaniuk approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 29, 2023
@dylhunn dylhunn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 30, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Jun 30, 2023

caretaker: failures are preexisting

@alxhub
Copy link
Member

alxhub commented Jun 30, 2023

This PR was merged into the repository by commit 925dad9.

alxhub pushed a commit that referenced this pull request Jun 30, 2023
@JeanMeche @alxhub
refactor(animations): Fix JSDoc comment (#50893)
33fea8e 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.

PR Close #50893
alxhub pushed a commit that referenced this pull request Jun 30, 2023
@JeanMeche @alxhub
refactor(platform-browser-dynamic): Fix JSDoc comment (#50893)
b9c28ca 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.

PR Close #50893
@alxhub alxhub closed this in 01e2bde Jun 30, 2023
alxhub pushed a commit that referenced this pull request Jun 30, 2023
@JeanMeche @alxhub
refactor(platform-browser-dynamic): Fix JSDoc comment (#50893)
925dad9 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.

PR Close #50893
@JeanMeche JeanMeche deleted the docs/internals-jsdoc branch July 12, 2023 08:07
sunilbaba pushed a commit to sunilbaba/angular that referenced this pull request Jul 26, 2023
@JeanMeche @sunilbaba
refactor(animations): Fix JSDoc comment (angular#50893)
4d26d9f 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.

PR Close angular#50893
sunilbaba pushed a commit to sunilbaba/angular that referenced this pull request Jul 26, 2023
@JeanMeche @sunilbaba
refactor(platform-browser-dynamic): Fix JSDoc comment (angular#50893)
d8d49ba 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.

PR Close angular#50893
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2023
thomasturrell pushed a commit to thomasturrell/angular that referenced this pull request Aug 29, 2023
@JeanMeche
refactor(animations): Fix JSDoc comment (angular#50893)
34eacc5 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.

PR Close angular#50893
thomasturrell pushed a commit to thomasturrell/angular that referenced this pull request Aug 29, 2023
@JeanMeche
refactor(platform-browser-dynamic): Fix JSDoc comment (angular#50893)
00f0916 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.

PR Close angular#50893
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
refactor(animations): Fix JSDoc comment (angular#50893)
34e09df 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.

PR Close angular#50893
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
refactor(platform-browser-dynamic): Fix JSDoc comment (angular#50893)
0b6d94a 
JSDoc comments should start with 2 stars or the annotations would not be picked up by the AIO workflow.

With this fix, the internal methods are no longer visible in the doc.

PR Close angular#50893
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@JeanMeche @dylhunn @alxhub @jessicajaniuk