Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo in navigation.json #48127

Closed
wants to merge 1 commit into from
Closed

docs: fix typo in navigation.json #48127

wants to merge 1 commit into from

Conversation

eltociear
Copy link
Contributor

documenation -> documentation

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@eltociear
docs: fix typo in navigation.json
3524b64 
documenation -> documentation
@pullapprove pullapprove bot requested a review from MarkTechson November 19, 2022 15:44
@ngbot ngbot bot added this to the Backlog milestone Nov 19, 2022
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 21, 2022
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 21, 2022
@AndrewKushnir
Copy link
Contributor

Caretaker note: typo fix, low risk, the current set of approvals should be enough to proceed with the merge.

AndrewKushnir
AndrewKushnir approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eltociear thanks for improving Angular docs 👍

@dylhunn
Copy link
Contributor

dylhunn commented Nov 21, 2022

This PR was merged into the repository by commit 4ce9650.

dylhunn pushed a commit that referenced this pull request Nov 21, 2022
@eltociear @dylhunn
docs: fix typo in navigation.json (#48127)
f612fce 
documenation -> documentation
PR Close #48127
@dylhunn dylhunn closed this in 4ce9650 Nov 21, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 22, 2022
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
@eltociear @trekladyone
docs: fix typo in navigation.json (angular#48127)
8f1e0dc 
documenation -> documentation
PR Close angular#48127
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@MarkTechson MarkTechson Awaiting requested review from MarkTechson

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@eltociear @AndrewKushnir @dylhunn @alan-agius4