Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: convert release package build scripts to typescript #46456

Closed

Conversation

devversion
Copy link
Member

Follow-up to: cce395a.

@devversion devversion force-pushed the convert-release-packager-ts branch from 6d2ce5f to 2eac7e2 Compare June 22, 2022 16:25
@jessicajaniuk jessicajaniuk added the area: build & ci Related the build and CI infrastructure of the project label Jun 22, 2022
@ngbot ngbot bot added this to the Backlog milestone Jun 22, 2022
@devversion devversion force-pushed the convert-release-packager-ts branch 3 times, most recently from d237f0a to 287d5e7 Compare June 22, 2022 20:20
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/build/angular-in-memory-web-api.mts Outdated Show resolved Hide resolved
scripts/build/package-builder.mts Show resolved Hide resolved
…ss forking

`ts-node` spawns a custom node launcher script and has a brotli-base64
encoded configuration that will point to the user-provided entry-point.

This breaks child process forking as we wouldn't be able to specify our
custom build worker and basically `ng-dev` would run inside `ng-dev`
again.
@devversion devversion force-pushed the convert-release-packager-ts branch from 287d5e7 to 5109953 Compare June 22, 2022 20:50
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 22, 2022
@devversion devversion marked this pull request as ready for review June 22, 2022 20:58
@devversion devversion added the target: patch This PR is targeted for the next patch release label Jun 22, 2022
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 63396a1.

AndrewKushnir pushed a commit that referenced this pull request Jun 22, 2022
AndrewKushnir pushed a commit that referenced this pull request Jun 22, 2022
…ss forking (#46456)

`ts-node` spawns a custom node launcher script and has a brotli-base64
encoded configuration that will point to the user-provided entry-point.

This breaks child process forking as we wouldn't be able to specify our
custom build worker and basically `ng-dev` would run inside `ng-dev`
again.

PR Close #46456
AndrewKushnir pushed a commit that referenced this pull request Jun 22, 2022
…ss forking (#46456)

`ts-node` spawns a custom node launcher script and has a brotli-base64
encoded configuration that will point to the user-provided entry-point.

This breaks child process forking as we wouldn't be able to specify our
custom build worker and basically `ng-dev` would run inside `ng-dev`
again.

PR Close #46456
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants