Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update angular #45117

Closed
wants to merge 3 commits into from
Closed

build: update angular #45117

wants to merge 3 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 17, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
@angular-devkit/build-angular 13.2.3 -> 13.2.5 age adoption passing confidence dependencies patch
@angular-devkit/build-angular 13.2.3 -> 13.2.5 age adoption passing confidence devDependencies patch
@angular-devkit/core 13.2.3 -> 13.2.5 age adoption passing confidence dependencies patch
@angular-devkit/schematics 13.2.3 -> 13.2.5 age adoption passing confidence dependencies patch
@angular/animations 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/cdk 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/cli 13.2.3 -> 13.2.5 age adoption passing confidence dependencies patch
@angular/cli 13.2.3 -> 13.2.5 age adoption passing confidence devDependencies patch
@angular/common 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/compiler 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/compiler-cli 13.2.2 -> 13.2.4 age adoption passing confidence devDependencies patch
@angular/core 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/dev-infra-private bd27798 -> 3398f08 age adoption passing confidence devDependencies digest
@angular/elements 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/forms 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/material 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/platform-browser 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/platform-browser-dynamic 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/router 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@angular/service-worker 13.2.2 -> 13.2.4 age adoption passing confidence dependencies patch
@schematics/angular 13.2.3 -> 13.2.5 age adoption passing confidence dependencies patch
angular/dev-infra 5b35e20 -> b710e5b age adoption passing confidence action digest

🔡 If you wish to disable git hash updates, add ":disableDigestUpdates" to the extends array in your config.


Release Notes

angular/angular-cli

v13.2.5

Compare Source

@​angular-devkit/build-angular
Commit Type Description
acf1e5e4a fix don't rename blocks which have a name
7a493979c fix update terser to 5.11.0

Special Thanks

Alan Agius and Paul Gschwendtner

v13.2.4

Compare Source

@​angular-devkit/build-angular
Commit Type Description
48c655ac9 fix update esbuild to 0.14.22
c0736ea0b fix update license-webpack-plugin to 4.0.2

Special Thanks

Alan Agius, Anner Visser and Charles Lyding

angular/angular

v13.2.4

Compare Source

animations
Commit Type Description
1a4b489692 perf improve algorithm to balance animation namespaces (#​45113)
core
Commit Type Description
cbd23ee0de perf make IterableDiffers and KeyValueDiffers tree-shakable (#​45094) (#​45115)

Special Thanks

Alan Cohen, AlirezaEbrahimkhani, Andrew Kushnir, Daniele Maltese, David Wolf, JoostK, Paul Gschwendtner, dario-piotrowicz and manuelkroiss

v13.2.3

Compare Source

animations
Commit Type Description
0050b01b62 perf made errors in the animations package tree shakeable (#​45079)
compiler
Commit Type Description
09f0254bdd perf chain element start/end instructions (#​44994)
core
Commit Type Description
92cf9fbebe fix ViewContainerRef.createComponent should consult module injector when custom one is provided (#​44966)

Special Thanks

AlirezaEbrahimkhani, Amer Yousuf, Andrew Kushnir, Aristeidis Bampakos, Dario Piotrowicz, Esteban Gehring, Jessica Janiuk, JiaLiPassion, Kristiyan Kostadinov, Mina Hosseini Moghadam, Patrick Cameron, Srdjan Milic, Yousaf Nawaz, dario-piotrowicz, markostanimirovic, mgechev and zuckjet

angular/components

v13.2.4

Compare Source

cdk
Commit Type Description
74bae85bc5 fix drag-drop: incorrectly sorting element inside dialog with blocked scrolling (#​14806)
81898ca5f6 fix drag-drop: stop pointer events on placeholder (#​24404)
material
Commit Type Description
6b76469b4a fix autocomplete: closing immediately when input is focused programmatically (#​21081)
3ea76419c8 fix autocomplete: use narrow value for aria-haspopup (#​15361)
9a12eabf6b fix button-toggle: unable to override elevation and high contrast styling applied incorrectly (#​14722)
cbd4b0ce4f fix checkbox: clear static aria attributes from host nodes (#​17092)
f6eaa7c1cf fix form-field: use correct color for form fields in high contrast mode (#​24422)
39d7834797 fix radio: clicks not propagating to wrapper elements (#​24459)
5988b8f77b fix radio: not checked on first click if partially visible (#​19505)
33716f124b fix select: arrow highlighted state not updating in Safari (#​15281)
fc204e4f4d fix sidenav: prevent focus from entering hidden sidenav if child element has a visibility
5e41a0ad09 fix tabs: use buttons for paginator also tab-header and mdc (#​24338)
material-experimental
Commit Type Description
4198f5b5dc fix mdc-dialog: align change detection with non-MDC version (#​24451)
45836f924d fix mdc-list: fix typo in action-list css class (#​24448)
7ca02495cd fix mdc-list: use body-1 rather than subtitle-1 typography for list items (#​24417)
c9a15476e8 fix mdc-select: target correct element with typography (#​24258)
bd3f39fb15 perf mdc-table: reduce bundle size (#​24309)

Special Thanks

Alireza Ebrahimkhani, Arthur Ming, Jeri Peier, Kristiyan Kostadinov, Miles Malerba, Paul Gschwendtner and renovate[bot]

v13.2.3

Compare Source

material
Commit Type Description
2c73b2df6 fix menu: position classes not update when window is resized (#​24385)
cdk-experimental
Commit Type Description
8c632ee87 fix column-resize: Fix bug in hover logic introduced by IE cleanup (#​24396)

Special Thanks

Karl Seamon, Kristiyan Kostadinov, Paul Gschwendtner, Zach Arend and Zack Elliott


Configuration

📅 Schedule: "after 10pm every weekday,before 4am every weekday,every weekend" in timezone America/Tijuana.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added action: review The PR is still awaiting reviews from at least one requested reviewer area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels Feb 17, 2022
@renovate renovate bot force-pushed the renovate/angular branch from 66897ef to 6aa720e Compare February 17, 2022 06:06
@ngbot ngbot bot modified the milestone: Backlog Feb 17, 2022
@pullapprove pullapprove bot requested review from alxhub and devversion February 17, 2022 06:06
@devversion devversion self-assigned this Feb 17, 2022
@renovate renovate bot force-pushed the renovate/angular branch from 6aa720e to 5777752 Compare February 17, 2022 12:48
@devversion devversion added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 17, 2022
@renovate renovate bot force-pushed the renovate/angular branch 3 times, most recently from 65c7d48 to c0ece81 Compare February 17, 2022 23:47
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 18, 2022
@devversion devversion removed their assignment Feb 18, 2022
@devversion devversion force-pushed the renovate/angular branch 2 times, most recently from 77ae7a2 to 22c8a3e Compare February 20, 2022 10:46
@renovate renovate bot force-pushed the renovate/angular branch 2 times, most recently from 5688e65 to 026f60c Compare February 24, 2022 17:15
@devversion
Copy link
Member

Ahh, renovate overriding my update again. need to push up my fixup

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: size-tracking

@pullapprove pullapprove bot requested a review from atscott February 24, 2022 19:54
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: size-tracking

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: size-tracking

@renovate renovate bot force-pushed the renovate/angular branch 2 times, most recently from a704d46 to d82b7a0 Compare February 24, 2022 21:47
@jessicajaniuk
Copy link
Contributor

@devversion I think we're needing another fixup.

@renovate renovate bot force-pushed the renovate/angular branch from d82b7a0 to 7b0a3b9 Compare February 25, 2022 00:00
renovate-bot and others added 3 commits February 25, 2022 12:56
Switches the Karma web test rule from `@bazel/concatjs` to our
wrapped/extended variant from the shared dev-infra code.

One benefit is that we now get a `_debug` target for web tests where
no browser is being launched and the action is kept alive. Allowing
developers to conveniently connect a browser manually for debugging.
Also works with iBazel for the manually connected browser.
Updates the AIO payload size golden to reflect the Angular
update as proposed by Renovate (see previous commit).

The main bundle got reduced and exceeded the threshold, so we needed
to update the golden. As part of this, all other bundle metrics are
updated even though not exceeding the threshold yet.
@devversion
Copy link
Member

Pushed again. I will dedicate some time now to stop Renovate from doing this in the future!

@devversion
Copy link
Member

devversion commented Feb 25, 2022

Ahh, @jessicajaniuk it seems to happen because you've ticked the Rebase /try checkbox in the PR description! I think that checkbox should not be checked if the PR is already merge ready (unless it has merge conflicts and no manual fixups).

@alan-agius4 just highlighted this in #45204

@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Feb 25, 2022

Ahh, @jessicajaniuk it seems to happen because you've ticked the Rebase /try checkbox in the PR description! I think that checkbox should not be checked if the PR is already merge ready (unless it has merge conflicts and no manual fixups).

@alan-agius4 just highlighted this in #45204

You are correct in that it shouldn't be checked unless necessary. However in this case there were merge conflicts making the rebase necessary. These renovate PRs seem to be more sensitive to conflicts.

Speaking of conflicts, this does not merge cleanly into 13.2.x. I'll switch to target: minor. Please create a patch PR to get this into 13.2.x.

@jessicajaniuk jessicajaniuk added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 25, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 63e9cc7.

jessicajaniuk pushed a commit that referenced this pull request Feb 25, 2022
Switches the Karma web test rule from `@bazel/concatjs` to our
wrapped/extended variant from the shared dev-infra code.

One benefit is that we now get a `_debug` target for web tests where
no browser is being launched and the action is kept alive. Allowing
developers to conveniently connect a browser manually for debugging.
Also works with iBazel for the manually connected browser.

PR Close #45117
jessicajaniuk pushed a commit that referenced this pull request Feb 25, 2022
Updates the AIO payload size golden to reflect the Angular
update as proposed by Renovate (see previous commit).

The main bundle got reduced and exceeded the threshold, so we needed
to update the golden. As part of this, all other bundle metrics are
updated even though not exceeding the threshold yet.

PR Close #45117
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2022
josmar-crwdstffng pushed a commit to josmar-crwdstffng/angular that referenced this pull request Apr 8, 2022
josmar-crwdstffng pushed a commit to josmar-crwdstffng/angular that referenced this pull request Apr 8, 2022
…5117)

Switches the Karma web test rule from `@bazel/concatjs` to our
wrapped/extended variant from the shared dev-infra code.

One benefit is that we now get a `_debug` target for web tests where
no browser is being launched and the action is kept alive. Allowing
developers to conveniently connect a browser manually for debugging.
Also works with iBazel for the manually connected browser.

PR Close angular#45117
josmar-crwdstffng pushed a commit to josmar-crwdstffng/angular that referenced this pull request Apr 8, 2022
…#45117)

Updates the AIO payload size golden to reflect the Angular
update as proposed by Renovate (see previous commit).

The main bundle got reduced and exceeded the threshold, so we needed
to update the golden. As part of this, all other bundle metrics are
updated even though not exceeding the threshold yet.

PR Close angular#45117
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants