misc ivy fixes #2 #27278

IgorMinar · 2018-11-26T22:24:40Z

No description provided.

This stuff is obsolete and shouldn't be here because we removed the JIT mode on CI.

mary-poppins · 2018-11-26T23:33:30Z

You can preview 027f06d at https://pr27278-027f06d.ngbuilds.io/.

mary-poppins · 2018-11-26T23:36:31Z

You can preview 97df9a9 at https://pr27278-97df9a9.ngbuilds.io/.

These paths are no longer needed / used. I had to disable one jit mode spec because it fails now that we actually run it. I root caused the jit test failure as missing forwardRef support. See FW-645.

There is no test in this diff because I've made a failing test pass.

There is no test in this diff because I'm making an already failing test pass.

…jector_def/ivy_build/app/test:test

mary-poppins · 2018-11-27T02:02:54Z

You can preview d5819c9 at https://pr27278-d5819c9.ngbuilds.io/.

kara

LGTM

packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel

packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel

Sounds like we need one more fix before we can turn this targets on.

PR Close #27278

…it (#27278) PR Close #27278

This stuff is obsolete and shouldn't be here because we removed the JIT mode on CI. PR Close #27278

) These paths are no longer needed / used. I had to disable one jit mode spec because it fails now that we actually run it. I root caused the jit test failure as missing forwardRef support. See FW-645. PR Close #27278

PR Close #27278

…27278) There is no test in this diff because I've made a failing test pass. PR Close #27278

There is no test in this diff because I'm making an already failing test pass. PR Close #27278

…jector_def/ivy_build/app/test:test (#27278) PR Close #27278

…gular#27278) PR Close angular#27278

…27278) PR Close angular#27278

…it (angular#27278) PR Close angular#27278

This stuff is obsolete and shouldn't be here because we removed the JIT mode on CI. PR Close angular#27278

…ular#27278) These paths are no longer needed / used. I had to disable one jit mode spec because it fails now that we actually run it. I root caused the jit test failure as missing forwardRef support. See FW-645. PR Close angular#27278

PR Close angular#27278

…ngular#27278) There is no test in this diff because I've made a failing test pass. PR Close angular#27278

…27278) There is no test in this diff because I'm making an already failing test pass. PR Close angular#27278

…jector_def/ivy_build/app/test:test (angular#27278) PR Close angular#27278

…gular#27278) PR Close angular#27278

…27278) PR Close angular#27278

…it (angular#27278) PR Close angular#27278

This stuff is obsolete and shouldn't be here because we removed the JIT mode on CI. PR Close angular#27278

…ular#27278) These paths are no longer needed / used. I had to disable one jit mode spec because it fails now that we actually run it. I root caused the jit test failure as missing forwardRef support. See FW-645. PR Close angular#27278

PR Close angular#27278

…ngular#27278) There is no test in this diff because I've made a failing test pass. PR Close angular#27278

…27278) There is no test in this diff because I'm making an already failing test pass. PR Close angular#27278

…jector_def/ivy_build/app/test:test (angular#27278) PR Close angular#27278

angular-automatic-lock-bot · 2019-09-14T18:21:45Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Nov 26, 2018

IgorMinar added 4 commits November 26, 2018 15:29

build: add aio/tools/examples/shared/node_modules to .bazelignore

807365c

ci(ivy): packages/core/test/render3 now passes with ivy aot

5fd36fe

ci(ivy): //packages/platform-browser-dynamic/test:test now works in jit

a0967d7

build(ivy): remove the remains of ivy-jit mode

c62cdf9

This stuff is obsolete and shouldn't be here because we removed the JIT mode on CI.

IgorMinar force-pushed the ivy/fixes branch from f6260ba to 027f06d Compare November 26, 2018 23:29

IgorMinar requested a review from kara November 27, 2018 00:22

IgorMinar added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Nov 27, 2018

IgorMinar added 5 commits November 26, 2018 17:58

fix(ivy): remove obsolete ng_module code for global and jit mode

0c09cb0

These paths are no longer needed / used. I had to disable one jit mode spec because it fails now that we actually run it. I root caused the jit test failure as missing forwardRef support. See FW-645.

test(ivy): add fixme to a failing testbed test

6f62cdc

fix(ivy): @Inject should not overwrite an existing ngInjectableDef

b7985c3

There is no test in this diff because I've made a failing test pass.

fix(ivy): @NgModule() should not require an metadata object

42985aa

There is no test in this diff because I'm making an already failing test pass.

test(ivy): root-case //packages/compiler-cli/integrationtest/bazel/in…

d5819c9

…jector_def/ivy_build/app/test:test

IgorMinar force-pushed the ivy/fixes branch from 97df9a9 to d5819c9 Compare November 27, 2018 01:58

kara approved these changes Nov 27, 2018

View reviewed changes

kara previously requested changes Nov 27, 2018

View reviewed changes

packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel Show resolved Hide resolved

packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel Show resolved Hide resolved

kara approved these changes Nov 27, 2018

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 27, 2018

jasonaden closed this in 198797b Nov 27, 2018

jasonaden pushed a commit that referenced this pull request Nov 27, 2018

ci(ivy): packages/core/test/render3 now passes with ivy aot (#27278)

d1227ec

PR Close #27278

jasonaden pushed a commit that referenced this pull request Nov 27, 2018

ci(ivy): //packages/platform-browser-dynamic/test:test now works in j…

04f902f

…it (#27278) PR Close #27278

jasonaden pushed a commit that referenced this pull request Nov 27, 2018

build(ivy): remove the remains of ivy-jit mode (#27278)

572fd7a

This stuff is obsolete and shouldn't be here because we removed the JIT mode on CI. PR Close #27278

jasonaden pushed a commit that referenced this pull request Nov 27, 2018

test(ivy): add fixme to a failing testbed test (#27278)

d35d164

PR Close #27278

jasonaden pushed a commit that referenced this pull request Nov 27, 2018

fix(ivy): @Inject should not overwrite an existing ngInjectableDef (#…

1cca27d

…27278) There is no test in this diff because I've made a failing test pass. PR Close #27278

jasonaden pushed a commit that referenced this pull request Nov 27, 2018

fix(ivy): @NgModule() should not require an metadata object (#27278)

5d82c73

There is no test in this diff because I'm making an already failing test pass. PR Close #27278

jasonaden pushed a commit that referenced this pull request Nov 27, 2018

test(ivy): root-case //packages/compiler-cli/integrationtest/bazel/in…

78e3a4c

…jector_def/ivy_build/app/test:test (#27278) PR Close #27278

JoostK mentioned this pull request Dec 2, 2018

fix(ivy): decorators should not overwrite existing Ivy definitions #27399

Closed

14 tasks

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

build: add aio/tools/examples/shared/node_modules to .bazelignore (an…

b662aa3

…gular#27278) PR Close angular#27278

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

ci(ivy): packages/core/test/render3 now passes with ivy aot (angular#…

e7a76e3

…27278) PR Close angular#27278

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

ci(ivy): //packages/platform-browser-dynamic/test:test now works in j…

b8c6ba3

…it (angular#27278) PR Close angular#27278

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

build(ivy): remove the remains of ivy-jit mode (angular#27278)

cf1ef77

This stuff is obsolete and shouldn't be here because we removed the JIT mode on CI. PR Close angular#27278

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

test(ivy): add fixme to a failing testbed test (angular#27278)

fe75332

PR Close angular#27278

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

test(ivy): root-case //packages/compiler-cli/integrationtest/bazel/in…

5f15564

…jector_def/ivy_build/app/test:test (angular#27278) PR Close angular#27278

ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

build: add aio/tools/examples/shared/node_modules to .bazelignore (an…

7f09fcc

…gular#27278) PR Close angular#27278

ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

ci(ivy): packages/core/test/render3 now passes with ivy aot (angular#…

d027076

…27278) PR Close angular#27278

ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

ci(ivy): //packages/platform-browser-dynamic/test:test now works in j…

65af016

…it (angular#27278) PR Close angular#27278

ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

build(ivy): remove the remains of ivy-jit mode (angular#27278)

2db4c50

This stuff is obsolete and shouldn't be here because we removed the JIT mode on CI. PR Close angular#27278

ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

test(ivy): add fixme to a failing testbed test (angular#27278)

386a735

PR Close angular#27278

ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(ivy): @Inject should not overwrite an existing ngInjectableDef (a…

756c897

…ngular#27278) There is no test in this diff because I've made a failing test pass. PR Close angular#27278

ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(ivy): @NgModule() should not require an metadata object (angular#…

eb35fbd

…27278) There is no test in this diff because I'm making an already failing test pass. PR Close angular#27278

ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

test(ivy): root-case //packages/compiler-cli/integrationtest/bazel/in…

13b8a39

…jector_def/ivy_build/app/test:test (angular#27278) PR Close angular#27278

kara added the comp: ivy label Feb 25, 2019

ngbot bot added this to the needsTriage milestone Feb 25, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

misc ivy fixes #2 #27278

misc ivy fixes #2 #27278

IgorMinar commented Nov 26, 2018

mary-poppins commented Nov 26, 2018

mary-poppins commented Nov 26, 2018

mary-poppins commented Nov 27, 2018

kara left a comment

angular-automatic-lock-bot bot commented Sep 14, 2019

misc ivy fixes #2 #27278

misc ivy fixes #2 #27278

Conversation

IgorMinar commented Nov 26, 2018

mary-poppins commented Nov 26, 2018

mary-poppins commented Nov 26, 2018

mary-poppins commented Nov 27, 2018

kara left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 14, 2019