Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update ngcontainer to bazel 0.18.0 #26465

Merged
merged 2 commits into from
Oct 15, 2018
Merged

build: update ngcontainer to bazel 0.18.0 #26465

merged 2 commits into from
Oct 15, 2018

Conversation

alexeagle
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@alexeagle alexeagle requested a review from gregmagolan October 15, 2018 23:07
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@alexeagle
build: update skylint to bazel 0.18
fca776c 
use .bazelignore file to ignore node_modules directory
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@mary-poppins
Copy link

You can preview fca776c at https://pr26465-fca776c.ngbuilds.io/.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@alexeagle alexeagle merged commit 31632b2 into angular:bazel Oct 15, 2018
gregmagolan pushed a commit to gregmagolan/angular that referenced this pull request Oct 16, 2018
@alexeagle @gregmagolan
build: update ngcontainer to bazel 0.18.0 (angular#26465)
75a7599 
* build: update ngcontainer to bazel 0.18.0

* build: update skylint to bazel 0.18

use .bazelignore file to ignore node_modules directory
gregmagolan pushed a commit to gregmagolan/angular that referenced this pull request Oct 16, 2018
@alexeagle @gregmagolan
build: update ngcontainer to bazel 0.18.0 (angular#26465)
1c5880d 
* build: update ngcontainer to bazel 0.18.0

* build: update skylint to bazel 0.18

use .bazelignore file to ignore node_modules directory
gregmagolan pushed a commit to gregmagolan/angular that referenced this pull request Oct 19, 2018
@alexeagle @gregmagolan
build: update ngcontainer to bazel 0.18.0 (angular#26465)
e3c73e0 
* build: update ngcontainer to bazel 0.18.0

* build: update skylint to bazel 0.18

use .bazelignore file to ignore node_modules directory
gregmagolan pushed a commit to gregmagolan/angular that referenced this pull request Oct 19, 2018
@alexeagle @gregmagolan
build: update ngcontainer to bazel 0.18.0 (angular#26465)
24a69a0 
* build: update ngcontainer to bazel 0.18.0

* build: update skylint to bazel 0.18

use .bazelignore file to ignore node_modules directory
IgorMinar pushed a commit that referenced this pull request Oct 20, 2018
@alexeagle @IgorMinar
build: update ngcontainer to bazel 0.18.0 (#26465) (#26488)
30d6233 
* build: update ngcontainer to bazel 0.18.0

* build: update skylint to bazel 0.18

use .bazelignore file to ignore node_modules directory

PR Close #26488
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
@alexeagle @sculove
build: update ngcontainer to bazel 0.18.0 (angular#26465) (angular#26488
fe322c9 
)

* build: update ngcontainer to bazel 0.18.0

* build: update skylint to bazel 0.18

use .bazelignore file to ignore node_modules directory

PR Close angular#26488
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@alexeagle @FrederikSchlemmer
build: update ngcontainer to bazel 0.18.0 (angular#26465) (angular#26488
330d2d0 
)

* build: update ngcontainer to bazel 0.18.0

* build: update skylint to bazel 0.18

use .bazelignore file to ignore node_modules directory

PR Close angular#26488
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexeagle @googlebot @mary-poppins @gregmagolan