sugest to reuse architecture direct golang instead of add java code ... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
MatejMagat305
commented
Jul 21, 2023
MatejMagat305
commented
Jul 21, 2023
| func (d *mobileDriver) Quit() { | ||
| app.Finish() | ||
| // Android and iOS guidelines say this should not be allowed! |
There was a problem hiding this comment.
this is quit instead back (call back) ...
MatejMagat305
commented
Jul 21, 2023
| keyCode := C.AKeyEvent_getKeyCode(e) | ||
| if (keyCode == C.AKEYCODE_BACK) { | ||
| println("back ok") | ||
| return 1 // Handle back button press and return handle |
There was a problem hiding this comment.
well here you can put send event to your architekture ...
MatejMagat305
commented
Jul 22, 2023
| if int(C.is_null(currentCtx)) == 1 { | ||
| RunOnJVM(func(vm, jniEnv, ctx uintptr) error { | ||
| env := (*C.JNIEnv)(unsafe.Pointer(jniEnv)) // not a Go heap pointer | ||
| C.deletePrevCtx(env, C.jobject(ctx)) |
| } | ||
| static int is_null(jobject ctx){ | ||
| if (ctx == NULL) return 1; | ||
| return 0; |
There was a problem hiding this comment.
2 small helper functions, if you have better replace its ...
| @@ -133,10 +122,12 @@ func callMain(mainPC uintptr) { | |||
|
|
|||
| //export onStart | |||
| func onStart(activity *C.ANativeActivity) { | |||
| C.set_global(activity) | |||
| } | |||
There was a problem hiding this comment.
set current referencies on start and resume ...
| show_file_save_method = find_static_method(env, current_class, "showFileSave", "(Ljava/lang/String;Ljava/lang/String;)V"); | ||
| finish_method = find_method(env, current_class, "finish", "()V"); | ||
| setCurrentContext(activity->vm, (*env)->NewGlobalRef(env, activity->clazz)); | ||
| } |
There was a problem hiding this comment.
re-set env at call function ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
well i know that i m litle bit enoying but i think the golang allow catch backbutton and it is not need change java