Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove savedstate projects from navigation playground #510

Closed
wants to merge 1 commit into from
Closed

Remove savedstate projects from navigation playground #510

wants to merge 1 commit into from

Conversation

dlam
Copy link
Member

@dlam dlam commented Mar 28, 2023

This also works around sending an empty test suite to FTL from savedstate-ktx that is currently causing failures.

Test: cd navigation && ./gradlew bOS
Change-Id: I94764a195b488210fd5af5e11079900ae4cc2a47

@dlam
Remove savedstate projects from navigation playground
0651b25 
This also works around sending an empty test suite to FTL from savedstate-ktx
that is currently causing failures.

Test: cd navigation && ./gradlew bOS
Change-Id: I94764a195b488210fd5af5e11079900ae4cc2a47
@dlam dlam requested a review from yigit March 29, 2023 18:03
yigit
yigit approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@yigit yigit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought we would just exclude savedstate-ktx, not both.

@dlam
Copy link
Member Author

dlam commented Mar 29, 2023 

~/r/g/a/f/s/navigation (dlam/fix-gh=) grep -Er "savedstate" ./**/build.gradle
./navigation-common/build.gradle:    api("androidx.savedstate:savedstate-ktx:1.2.1")
./navigation-common/build.gradle:    api("androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.1")
./navigation-compose/build.gradle:    androidTestImplementation(projectOrArtifact(":lifecycle:lifecycle-viewmodel-savedstate"))
./navigation-compose/samples/build.gradle:    implementation("androidx.savedstate:savedstate-ktx:1.2.1")
./navigation-compose/samples/build.gradle:        substitute(module("androidx.lifecycle:lifecycle-viewmodel-savedstate:")).
./navigation-compose/samples/build.gradle:                using project(":lifecycle:lifecycle-viewmodel-savedstate")
./navigation-safe-args-generator/build.gradle:    testImplementationAarAsJar(project(":lifecycle:lifecycle-viewmodel-savedstate"))

turns out we don't really need either!

@dlam dlam deleted the dlam/fix-gh branch August 21, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yigit yigit yigit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlam @yigit