Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added treeitem role to tree items. Updated a few devDependencies. #182

Merged
merged 8 commits into from
Dec 20, 2019
Merged

Added treeitem role to tree items. Updated a few devDependencies. #182

merged 8 commits into from
Dec 20, 2019

Conversation

I-Vargas
Copy link
Contributor

Here's the pull request with what I was talking about in #181 issue. Could you merge and release as 0.2.70?

@I-Vargas
Copy link
Contributor Author

I-Vargas commented Dec 11, 2019

Second commit updating all the possible dependencies without breaking the build. The only dependency that wasn't updated was rollup-plugin-vue that stayed at 4.6.1 because 4.6.2 onward with the latest being 5.1.4 breaks the build.

If you don't want to merge this one, at least merge the first one that was just a small change.

@I-Vargas
Copy link
Contributor Author

I-Vargas commented Dec 11, 2019

I've updated eslint and introduced vue-cli-service. As a suggestion you could try and convert the entire project to vue-cli-service and use it instead of rollup for a version 0.3.

Please check the commits (and don't mind the broken .eslintrc.js on the 3rd commit, I fixed it on the 4th) and see if it's something useful for the project and merge it.

With this I'll close #181 now.

Edit: You should really update your tests add more. The code is barely tested. Especially the asynchronous behaviour and the RequestFrameAnimation part.

@I-Vargas
Copy link
Contributor Author

Just saw PR #183 that was a lot more elegant fix than my way to get rid of the errors I mention in the 3rd commit.

@I-Vargas
Copy link
Contributor Author

@amsik could you review the pull requests?

@I-Vargas
Copy link
Contributor Author

@amsik done.

@amsik amsik merged commit ab6b428 into amsik:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants