create a static version of amp.dev #6472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
netlify bot hasnt been configured, so their failures are expected |
|
ping @sebastianbenz |
with '#' will be ignored, and an empty message aborts the commit. # # On branch static-version # Your branch is up to date with 'origin/static-version'. # # Changes to be committed: # modified: gulpfile.js/build.js # modified: netlify/configs/amp.dev/netlify.toml # .github/workflows/check-grow-link-integrity.yaml # modified: .github/workflows/lint-js.yaml # modified: .github/workflows/test-playground.yaml # # Untracked files: # .github/workflows/release-static-production.yml #
|
@patrickkettner What's the status of this? From my point of view this looks good, once build.js has been split up. |
|
I am splitting it up. had been working on the github action portion. will ping you on this once its separated |
|
@sebastianbenz build passes |
sebastianbenz
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.