🐳 Add dockerfile for development and instructions to use it #6041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbenz
approved these changes
Jul 13, 2021
README.md
Outdated
| After the image has been successfully built start a container with the following command: | ||
|
|
||
| ```sh | ||
| docker run -v "$(pwd)"/pages/content:/amp-dev/pages/content --publish 8080:8080 -t amp.dev |
There was a problem hiding this comment.
Can we turn these into a script?
Co-authored-by: Sebastian Benz <sebastian.benz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described.
This also updates dependencies and installs them with
npm install --no-optionalthis makes surefseventsis not tried to be installed in non-Darwin environments and also fixes the failing renovate-bot PRs.