Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix playground amp-script hash generation #5888

Merged
merged 1 commit into from
May 20, 2021
Merged

fix playground amp-script hash generation #5888

merged 1 commit into from
May 20, 2021

Conversation

patrickkettner
Copy link
Collaborator

fixes #5887

@patrickkettner
Copy link
Collaborator Author

webpack 5 removed automatic polyfilling of node apis. fixing the Buffer error that was being logged exposed an issue where createHash didn't exist (crypto-es, which was being mapped to crypto doesn't provide it). This probably breaks something else, but I am not sure what is using crpyto-es fallbackj currently

@patrickkettner patrickkettner merged commit eef678f into future May 20, 2021
@patrickkettner patrickkettner deleted the hash-fix branch May 20, 2021 23:43
@kristoferbaxter
Copy link
Contributor

Thanks for fixing so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

@matthiasrohmer matthiasrohmer Awaiting requested review from matthiasrohmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Script hash generation broken in playground
3 participants
@patrickkettner @kristoferbaxter @sebastianbenz