🚧 New homepage #5785
Merged
🚧 New homepage #5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,13 @@ | |||
| <symbol id="logo-outline" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 194 194"> | |||
There was a problem hiding this comment.
Inline this SVG as it's one-off use currently. There also is a new icon mechanism in place that uses an external and hence cacheable SVG document.
There was a problem hiding this comment.
@matthiasrohmer is there documentation for new icon mechanism in place that uses an external and hence cacheable SVG document? Is that in place of using a sprite structure? We control color-reversing and gradients from CSS; which is the only way we know how to do it. We're not aware of a way to control an external SVG using <style-amp> elements. But perhaps you are not doing any special treatment for logo-outline. But other amp-menu symbols (SVG) are in a sprite, nu?
Enriqe
pushed a commit
to Enriqe/amp.dev
that referenced
this pull request
May 17, 2021
* 🎉 Begin work on new home * 🍱 Add new logo * 🚧 Add data * ✨ Add new stage * ✨ Add new formats section * ✨ Add teaser carousel with intro * 🐛 Remove comment * 💄 Adjust box-shadow * ♻️ Move teaser to component * ♻️ Remove variable * ♻️ Rename classes * 💄 Add introduction component styling * 💄 Adjust section width * 💄 Adjust stage sizing * 💄 Add some margins * 💄 Enhance basic carousel arrow styles * 💄 Add teaser carousel styles * ✨ Add pagination to teaser-carousel * ♻️ Calculate magic number with sass * 💄 Adjust breakpoints * 💬 Update copy according to localization docs * 🚚 Move style files * 💄 Hide link * 💄 Remove duplicate class delcaration * 💄 Update stage styles * 💄 Update carousel styles * 💄 Update formats styles * 💫 Add basic animation * 💄 Increase specificity Co-authored-by: Matthias Rohmer <12857772+matthiasrohmer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.