Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashes, not underscores #5780

Merged
merged 1 commit into from
May 10, 2021
Merged

dashes, not underscores #5780

merged 1 commit into from
May 10, 2021

Conversation

patrickkettner
Copy link
Collaborator

fixes #5775

@patrickkettner
Copy link
Collaborator Author

fwiw, these have been in there since @filip added it back on amp by example, not sure if there was ever a practical reason as to why

@sebastianbenz
Copy link
Collaborator

I don't think so...this list might be outdated as well

@fstanis how did you generate this?

@matthiasrohmer matthiasrohmer merged commit 5cbe580 into future May 10, 2021
@matthiasrohmer matthiasrohmer deleted the fix-invalid-sugestions branch May 10, 2021 11:48
Enriqe pushed a commit to Enriqe/amp.dev that referenced this pull request May 17, 2021
@patrickkettner @Enriqe
dashes, not underscores (ampproject#5780)
775af98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasrohmer matthiasrohmer matthiasrohmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playground suggesting invalid layout
3 participants
@patrickkettner @sebastianbenz @matthiasrohmer