Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional survey #5533

Merged
merged 3 commits into from
Mar 19, 2021
Merged

functional survey #5533

merged 3 commits into from
Mar 19, 2021

Conversation

patrickkettner
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the problem? Looks good once the build passes.


{% do survey_questions.update({"_url": request.url })%}
{{ survey_questions | tojson }}
[% set survey = surveys|random|survey(fixedQuestions, url) %]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the random do here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surveys is an array of survey objects. random picks one of the available objects at runtime

Co-authored-by: Matthias Rohmer <12857772+matthiasrohmer@users.noreply.github.com>
@patrickkettner
Copy link
Collaborator Author

@sebastianbenz

What was the problem? Looks good once the build passes.

The issue I was hitting is still an issue, but it was completely orthogonal to getting it to work. @matthiasrohmer was able to set me straight, I had to pass the object from grow to SSR, and then use different tags to pull in a version at request time, rather than at deploy time.

@patrickkettner patrickkettner merged commit 656d8c2 into future Mar 19, 2021
@patrickkettner patrickkettner deleted the survey-with-a-vengeance branch March 19, 2021 05:03
sebastianbenz added a commit that referenced this pull request Mar 19, 2021
sebastianbenz added a commit that referenced this pull request Mar 19, 2021
@patrickkettner patrickkettner mentioned this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants