🎉 Update grow to v1.0.0 #5292
🎉 Update grow to v1.0.0 #5292
Conversation
|
|
||
| messages = manager.ServerMessages() | ||
| messages.add_message('Pod:', pod.root, colors.HIGHLIGHT) | ||
| messages.add_message('Server:', url_root, colors.HIGHLIGHT) |
There was a problem hiding this comment.
Since the idea of this extension is to silence the startup log and we are not printing them anyway, this can be removed.
| messages.add_message( | ||
| 'Ready.', 'Press ctrl-c to quit.', colors.SUCCESS, colors.SUCCESS) |
| @@ -52,7 +52,7 @@ class MarkdownInHtmlExtension(extensions.BaseExtension): | |||
| def __init__(self, pod, config): | |||
| super(MarkdownInHtmlExtension, self).__init__(pod, config) | |||
|
|
|||
| if config.has_key(CLEAR_EXTRA_EXTENSIONS_FLAG) and config.get(CLEAR_EXTRA_EXTENSIONS_FLAG): | |||
| if config.__contains__(CLEAR_EXTRA_EXTENSIONS_FLAG) and config.get(CLEAR_EXTRA_EXTENSIONS_FLAG): | |||
There was a problem hiding this comment.
Hm... if config.get(CLEAR_EXTRA_EXTENSIONS_FLAG, None) should actually be enough. Methods pre- and postfixed with __ are not meant to be called directly.
|
Nice, thanks so far, Leo! How many rendering issues are there? And can you briefly summarize in which categories they fall? |
|
Extremely excited about this. Please hurry, so that I might not have to setup python 2.7 on my new notebook ;-)! |
matthiasrohmer
force-pushed
the
grow-1-update
branch
from
c8e7a72 to
5131d0b
Compare
|
Things work in general. Build times did increase by ~30%, this needs to be investigated. Besides that there are strange things with the code formatting that @lluerich looks into. |
|
|
Note: that's a breaking change for previous contributors to amp.dev. To get amp.dev running again on your local machine, coming from Python 2.7 perform the following steps. |
|
I believe we have PATH changes in the README, so I think that would likely
need to be updated as well, no?
…On Tue, Feb 9, 2021 at 11:43 AM Matthias Rohmer ***@***.***> wrote:
Note: that's a breaking change for previous contributors to amp.dev. To
get amp.dev running again on your local machine, coming from Python 2.7
perform the following steps.
pip uninstall grow
# This will install Python 3. Skip if already present
brew install python
# Install Grow 1 using a Python 3 environment
pip3 install grow
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5292 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADRUBQ7O4XR2GMEDEQ3GXDS6FQ4JANCNFSM4W6NGOCA>
.
--
patrick
|
|
Hm... you are correct. Update most parts of it but we still use |
This is a work in progress as I am still dealing with a couple of errors during the build.
Once merged it will fix #5110.