shim "this" reference in playground #5277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sebastianbenz
approved these changes
Jan 29, 2021
patrickkettner
commented
Jan 29, 2021
| @@ -1,4 +1,5 @@ | |||
| const path = require('path'); | |||
| const webpack = require('webpack'); | |||
There was a problem hiding this comment.
add webpack, in order to call webpack.DefinePlugin
patrickkettner
commented
Jan 29, 2021
| @@ -20,6 +21,9 @@ module.exports = (env, argv) => { | |||
| sourceMapFilename: '[name].map', | |||
| publicPath: '', | |||
| }, | |||
| node: { | |||
There was a problem hiding this comment.
webpack node configuration
patrickkettner
commented
Jan 29, 2021
| @@ -20,6 +21,9 @@ module.exports = (env, argv) => { | |||
| sourceMapFilename: '[name].map', | |||
| publicPath: '', | |||
| }, | |||
| node: { | |||
| global: false, | |||
There was a problem hiding this comment.
tell webpack to not include the polyfill
patrickkettner
commented
Jan 29, 2021
| @@ -43,6 +47,9 @@ module.exports = (env, argv) => { | |||
| }, | |||
| }, | |||
| plugins: [ | |||
| new webpack.DefinePlugin({ | |||
| global: '(typeof globalThis ? globalThis : self)', | |||
There was a problem hiding this comment.
rather than use the polyfill that we are telling webpack to not use above, use this string of code.
When a module is trying to use global, webpack will regex in this string of code. if globalThis is defined, use it. If it is not defined, use self, since it is available in worker and DOM, and is a shorter string than "window".
|
I added comments inline, but here is a diff
It is a 0.061% filesize (680b in 1.1MB file) increase |
|
Thanks for explaining! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5272, not sure how to fully test the playground, however