Disable double tap to zoom to improve FID #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkettner
approved these changes
Dec 10, 2020
|
wonderful discovery! |
robinvanopstal
added a commit
that referenced
this pull request
Dec 11, 2020
* future: (25 commits) Add CSP Headers (#5052) Updated MakeStories Screenshot (#5068) fix boilerplate formatting (#5069) fix missing viewports Update dependency @babel/core to v7.12.10 (#5058) use data-css-strict on amp4email (#5054) Update dependency mini-css-extract-plugin to v1.3.3 (#5067) Update dependency @babel/node to v7.12.10 (#5059) Update dependency @babel/preset-env to v7.12.10 (#5061) Update dependency svg-spritemap-webpack-plugin to v3.8.1 (#5062) Update dependency @babel/cli to v7.12.10 (#5057) Disable double tap to zoom to improve FID (#5063) disable survey banner (#5064) Update dependency rss-to-json to v1.1.2 (#5051) Consider missing loadingExperience in api result (#5044) remove draft posts (#5046) substring strings, rather than array indices (#5050) update old amp-by-example samples (#5049) Update dependency copy-webpack-plugin to v6.4.0 (#5036) Update dependency js-yaml to v3.14.1 (#5039) ...
|
This seems to have improved the FID stats on amp.dev, congrats! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For background see
https://www.google.com/url?q=https://bugs.chromium.org/p/chromium/issues/detail?id%3D1108987&sa=D&usg=AFQjCNEbEVB7yYOkxIKuB9z6v9m2Vpf0SA
and for the recommend fix https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away