Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use data-css-strict on amp4email #5054

Merged
merged 1 commit into from
Dec 10, 2020
Merged

use data-css-strict on amp4email #5054

merged 1 commit into from
Dec 10, 2020

Conversation

patrickkettner
Copy link
Collaborator

fixes #5053

sebastianbenz
sebastianbenz requested changes Dec 10, 2020
View reviewed changes
Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

examples/source/1.components/amp-autocomplete.html Outdated Show resolved Hide resolved
sebastianbenz
sebastianbenz approved these changes Dec 10, 2020
View reviewed changes
Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patrickkettner patrickkettner merged commit 78e9add into future Dec 10, 2020
@patrickkettner patrickkettner deleted the use-data-css-strict branch December 10, 2020 18:04
robinvanopstal added a commit that referenced this pull request Dec 11, 2020
@robinvanopstal
Merge branch 'future' into feature/frontend21-components
4c68802 
* future: (25 commits)
  Add CSP Headers (#5052)
  Updated MakeStories Screenshot (#5068)
  fix boilerplate formatting (#5069)
  fix missing viewports
  Update dependency @babel/core to v7.12.10 (#5058)
  use data-css-strict on amp4email (#5054)
  Update dependency mini-css-extract-plugin to v1.3.3 (#5067)
  Update dependency @babel/node to v7.12.10 (#5059)
  Update dependency @babel/preset-env to v7.12.10 (#5061)
  Update dependency svg-spritemap-webpack-plugin to v3.8.1 (#5062)
  Update dependency @babel/cli to v7.12.10 (#5057)
  Disable double tap to zoom to improve FID (#5063)
  disable survey banner (#5064)
  Update dependency rss-to-json to v1.1.2 (#5051)
  Consider missing loadingExperience in api result (#5044)
  remove draft posts (#5046)
  substring strings, rather than array indices (#5050)
  update old amp-by-example samples (#5049)
  Update dependency copy-webpack-plugin to v6.4.0 (#5036)
  Update dependency js-yaml to v3.14.1 (#5039)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add data-css-strict to all email samples
2 participants
@patrickkettner @sebastianbenz