Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Playground: Only render a learn more link if a URL exists #5045

Merged
merged 1 commit into from
Dec 8, 2020
Merged

🐛 Playground: Only render a learn more link if a URL exists #5045

merged 1 commit into from
Dec 8, 2020

Conversation

robinvanopstal
Copy link
Contributor

Fixes: #5027

@robinvanopstal robinvanopstal changed the title 🐛 Check the presence of an URL before rendering a learn more link 🐛 Playground: Only render a learn more link if a URL exists Dec 8, 2020
sebastianbenz
sebastianbenz approved these changes Dec 8, 2020
View reviewed changes
Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sebastianbenz sebastianbenz merged commit 299a1ea into future Dec 8, 2020
@sebastianbenz sebastianbenz deleted the fix/playground-learn-more-link branch December 8, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playground: don't show learn more link on validation errors if there is nothing to learn more
2 participants
@robinvanopstal @sebastianbenz