Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Stop replacing HTML entities in Pixi #4649

Merged
merged 4 commits into from
Sep 22, 2020

Conversation

matthiasrohmer
Copy link
Collaborator

This fixes AMP to RTV 002009190410000 where ampproject/amphtml#27153 should be fixed. Quick test I've done with <test> in one of the recommendations worked fine.

Copy link
Collaborator

@caroqliu caroqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! 🎉

@matthiasrohmer matthiasrohmer merged commit 30aae67 into future Sep 22, 2020
@matthiasrohmer matthiasrohmer deleted the feature/pixi/amp-script-update branch September 22, 2020 20:09
robinvanopstal added a commit that referenced this pull request Sep 23, 2020
* future:
  Add amp-optimizer as well. (#4539)
  ♻️ Stop replacing HTML entities in Pixi (#4649)
  Hide other elements for field data error state (#4639)
  Rename red (#4642)
robinvanopstal added a commit that referenced this pull request Sep 23, 2020
* future:
  🐛  Remove deprecated loading indicator to prevent duplicated CSS (#4652)
  Add amp-optimizer as well. (#4539)
  ♻️ Stop replacing HTML entities in Pixi (#4649)
  Hide other elements for field data error state (#4639)
  Rename red (#4642)
  💄 Pixi - Input error styling (#4627)

# Conflicts:
#	frontend/scss/components/molecules/pixi-status-intro.scss
matthiasrohmer added a commit that referenced this pull request Sep 23, 2020
matthiasrohmer added a commit that referenced this pull request Sep 23, 2020
robinvanopstal added a commit that referenced this pull request Sep 23, 2020
* future:
  Revert "♻️ Stop replacing HTML entities in Pixi (#4649)" (#4655)
robinvanopstal added a commit that referenced this pull request Sep 23, 2020
* future:
  Revert "♻️ Stop replacing HTML entities in Pixi (#4649)" (#4655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants