Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️ Stop preloading fonts in favor of font-display: swap #4533

Merged
merged 1 commit into from
Sep 15, 2020
Merged

⚡️ Stop preloading fonts in favor of font-display: swap #4533

merged 1 commit into from
Sep 15, 2020

Conversation

matthiasrohmer
Copy link
Collaborator

font-display: swap; is already set, this simply removes the preload statements.

@google-cla google-cla bot added the cla: yes label Sep 15, 2020
@matthiasrohmer matthiasrohmer merged commit de58921 into future Sep 15, 2020
@matthiasrohmer matthiasrohmer deleted the perf/font-preload branch September 15, 2020 19:46
@patrickkettner
Copy link
Collaborator

any insight into the impact?

@kevinkimball
Copy link

@patrickkettner Kris asked me to take a look at this PR, so I ran the numbers and it appears to be 6% - 14% faster

@matthiasrohmer
Copy link
Collaborator Author

Thanks a lot @kevinkimball for providing the numbers! Totally forgot about this.

@matthiasrohmer matthiasrohmer mentioned this pull request Dec 3, 2020
Closed
@matthiasrohmer matthiasrohmer mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinvanopstal robinvanopstal robinvanopstal approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiasrohmer @patrickkettner @kevinkimball @robinvanopstal