Fixing AMP Start 2 demo path names to images. #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the images got moved during reorg of files so the mock API calls were not returning images correctly. In other cases the referenced file did not exist at all, so I put a filename in of a different file that seemed close. There were also some incorrect file types in extensions.
added 2 commits
November 1, 2019 15:58
|
Sorry, forgot to create new branch for committing the next files. The new CSS file is meant for a separate PR. Reverted. |
matthiasrohmer
approved these changes
Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the images got moved during a reorg of files so the mock API calls were not returning images correctly. In other cases the referenced file did not exist at all, so I put a filename in of a different file that seemed close. There were also some incorrect file types in extensions.
(This used to be a part of PR #2767 but separating into smaller independent PRs.)