Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Switch relative to absolute paths #2603

Merged
merged 2 commits into from
Jul 25, 2019

Conversation

lluerich
Copy link
Collaborator

fixes #2599

@fstanis
Copy link
Collaborator

fstanis commented Jul 24, 2019

Thanks!

Should we also update images to not use https://amp.dev directly, like e.g.

<amp-img class="m1" width="600" height="314" layout="responsive" src="https://amp.dev/static/img/sharing/default-600x314.png"></amp-img>

examples/static/samples/standalone/amp-email/index.html also has a few "hardcoded" domain links, not sure what that file is used for.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@matthiasrohmer matthiasrohmer merged commit 6a75e58 into future Jul 25, 2019
@matthiasrohmer matthiasrohmer deleted the fix/amp4email-absolute-urls branch July 25, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use absolute URLs in email samples
5 participants