💄Update boilerplate generator theme #2047
Conversation
lluerich
changed the title
|
Forgot to add screenshots: |
matthiasrohmer
requested review from
sebastianbenz
and removed request for
matthiasrohmer
There was a problem hiding this comment.
Thanks a lot for looking into this!
One thing: can we change the behavior of the format toggle:
- collapse the toggle when clicking on the first, currently selected, format
- collapse the toggle when selecting a different format
This is not a problem with the normal format selector as it always reloads the page.
| @@ -0,0 +1,80 @@ | |||
| /* | |||
| Monokai style | |||
There was a problem hiding this comment.
I think a better place for this would be /frontend/scss/.
There was a problem hiding this comment.
It would indeed be a better place, but I forgot that the boilerplate generator uses it;s own build. So, please ignore and leave things as they are :-).
There was a problem hiding this comment.
So should I revert the changes completely or just leave them in the state I submitted yesterday? :-)
|
I changed the behaviour of the dropdown to only open on click, because I saw no way to have both the hover effect and let the dropdown collapse once something is selected or the selected item is clicked. |
👍 Two other things I've noticed now that the hover is gone, can you please:
We also should take a look at the normal format switcher //cc @matthiasrohmer |
|
Thanks! ...and I'm sorry, but I forgot two other things:
|
|
Perfect! Thanks! |
fixes #1697