prepare for prod #1385
Merged
prepare for prod #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbenz
force-pushed
the
prod
branch
2 times, most recently
from
b00240b to
de2818e
Compare
|
Hot tip, you can use the new draft PR feature :) See https://twitter.com/github/status/1096093162345508864 |
|
Oooooh nice! Thanks!
|
|
@pbakaus I think this is good to merge - PTAL There are a few things I plan to do in the next PRs:
|
pbakaus
approved these changes
Feb 20, 2019
package.json
Outdated
| @@ -1,9 +1,12 @@ | |||
| { | |||
| "name": "amp-dev", | |||
| "version": "1.0.2", | |||
| "description": "The successor of the former ampproject.org: the all-new amp.dev", | |||
| "description": "The Amp project website.", | |||
There was a problem hiding this comment.
Suggested change
| "description": "The Amp project website.", | |
| "description": "The AMP Project website.", |
|
Fixed the nit. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.