Final feature push for amp.dev 1.0 #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/hbs/partials/header.hbs # frontend/templates/views/detail/component-detail.j2 # frontend/templates/views/examples/manual.j2
…p.dev into refactor/examples
# Conflicts: # pages/content/amp-dev/documentation/guides-and-tutorials/start/visual_story/create_cover_page.md
…into origin/future
…into origin/future
…into origin/future * 'origin/future' of https://github.com/jungvonmatt/amp.dev: ✨ Add featured documents to ads landing page 🔥 Remove unused shared hints # Conflicts: # pages/content/amp-dev/documentation/guides-and-tutorials/index.ads.html
…into origin/future
…into origin/future
…into origin/future
…into origin/future
…into origin/future
…into origin/future * 'origin/future' of https://github.com/jungvonmatt/amp.dev: add links to about sites
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
robinvanopstal
added a commit
to jungvonmatt/amp.dev
that referenced
this pull request
Feb 8, 2019
* future: (31 commits) Only use environment variables for GitHub authentication (ampproject#1380) Fixes for build (ampproject#1379) 🐛 Fix broken references. (ampproject#1378) use correct logging command disable interactive logging for grow disable signale logging for grow try explicit grow path for travis check grow install folder remove import flag added tip in docs (disabled for now to fix positioning), improved landing pages, imported doc changes fix syntax error pass env variables to process starting grow fix playground build build site during script use different service account fix lint errors fix path fix playground tests Final feature push for amp.dev 1.0 (ampproject#1377) fix playground build ... # Conflicts: # platform/lib/pipeline/componentReferenceLinker.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one includes all the work that we've done today. Highlights are:
✨ Samples are in a lot better shape though a lot of work still needs to be done. Special thanks to @sebastianbenz for all the support until now.
💄The format color schemes has been updated to pass a11y.
⚡️ Everything marked as
draft: truewill not appear in the sidebar🌐 Subcollection titles have been translated
🎉 Guides and Tutorial landing pages have been implemented
🍱 Experimental features and Common attributes have been migrated (@CrystalOnScript, I put them into Learn, feel free to move around)
🐛 An immense amount of bug fixes and improvements