-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.14.3 #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention supported operating systems. Refs #548
Add python 3.9
Let Command know about baked call args when wrapping the module
Rip out test running code in sh.py, and attempts in test.py to set up coverage. Instead, let Actions script handle coverage and env var matrix.
Switch from Travis to GitHub Actions
CWD may be /tmp on some systems
fix flaky test
Fix #597. I decided to not add an additional import for `pathlib.Path` and instead check if the object passed is "path-like" according to [PEP-519](https://www.python.org/dev/peps/pep-0519/).
This is an exception to the rule and is needed to provide backwards compatibility.
While Python 3.5 introduced pathlib, __fspath__ wasn't introduced until Python 3.6
This fixes a deadlock by only locking the assignment of self.exit_code
Accept pathlib.Path objects for stdout/stderr
Allow done callback to access RunningCommand
Make sh.which() an internal function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.