Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Amber::VERSION #160

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Update Amber::VERSION #160

merged 1 commit into from
Aug 3, 2017

Conversation

faustinoaq
Copy link
Contributor

@faustinoaq faustinoaq commented Aug 2, 2017 •
edited
Loading

Description of the Change

Update Amber to latest version.

Alternate Designs

Maybe we can automate this?

Why Should This Be In Core?

Because Amber::VERSION is shown when app starts:

I, [2017-08-02 11:30:00 -0500 #25107]  INFO -- : [Amber 0.1.4] serving application "App." at http://0.0.0.0:3000
I, [2017-08-02 11:30:00 -0500 #25107]  INFO -- : Server started in development.
I, [2017-08-02 11:30:00 -0500 #25107]  INFO -- : Startup Time 00:00:00.0005190

Benefits

Correct information is shown.

Possible Drawbacks

Need to update manualy every version.

Applicable Issues

#159

@eliasjpr eliasjpr self-requested a review August 2, 2017 16:55
eliasjpr
eliasjpr approved these changes Aug 2, 2017
View reviewed changes
Copy link
Contributor

@eliasjpr eliasjpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elorest
Copy link
Member

elorest commented Aug 2, 2017

This actually is automated but if one of them is updated manually without the other then version.cr will fail because it's doing a find and replace on current version from shard.yml

@faustinoaq
Copy link
Contributor Author

actually is automated but if one of them is updated manually without the other then version.cr will fail

So, Somebody changed it manually?

@elorest elorest merged commit f40574f into amberframework:master Aug 3, 2017
marksiemers pushed a commit to marksiemers/amber that referenced this pull request Oct 28, 2017
@faustinoaq @elorest
Update Amber::VERSION (amberframework#160)
29d3608
elorest pushed a commit that referenced this pull request Nov 17, 2017
@faustinoaq @elorest
Update Amber::VERSION (#160)
8006fd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasjpr eliasjpr eliasjpr approved these changes

@elorest elorest elorest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faustinoaq @elorest @eliasjpr