-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix hiding edge tooltip when a node is hovered #4026
base: develop
Are you sure you want to change the base?
Conversation
@yotamberk could you tag this one as |
@Gelio thanks for the sending this PR with the fix! appreciate the screenshot as well 😄 Curious, could you provide a new example that we can use to verify the fix, or point us to an existing example that shows the bug behavior (and would also show the fix)? https://github.com/almende/vis/tree/master/examples/network said another way, could you provide steps to test this PR? |
@micahstubbs Sure, no problem. Take a look at data/scalingNodesEdges.html.
The tooltip does not disappear, even though the edge is technically not visible now since the node is on top of it. |
@Gelio thanks for the steps to test! the fix looks good to me ✅ http://127.0.0.1:51702/examples/network/data/scalingNodesEdgesLabels.html beforeafter |
@micahstubbs Awesome 👍 Thank you for verifying it and providing the gifs 😄 |
@Gelio of course! I've accepted this improvement over on our community fork https://github.com/visjs-community/visjs-network visjs-community/visjs-network#26 hopefully the maintainers here will see the review and accept the PR as well 😄 |
@micahstubbs Great, thanks 😃 |
💌 Thanks @Gelio for your contribution! |
When supplying an edge tooltip (
title
) without providing a node tooltip (title
), the edge's tooltip will be displayed even though the node is hovered and the tooltip is in the background.This PR fixes that behavior.