feat(sol-macro): add event filters to contracts #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Mar 12, 2024
Comment on lines
+341
to
+346
| quote! { | ||
| #[doc = #doc] | ||
| pub fn #name(&self) -> alloy_contract::Event<N, T, &P, #event_name> { | ||
| self.event_filter::<#event_name>() | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we make these default snake case? I realize that for function doStuff we codegen foo.doStuff().send() atm
There was a problem hiding this comment.
Currently we default everything to the same name as declared in solidity/ABI. It's possible in the future to implement renaming like in serde but currently there is no real demand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to alloy-rs/alloy#274
Example usage: https://github.com/alloy-rs/alloy/blob/14a797b42cbfbdc857f0b0265e7c562df63d7f98/crates/contract/src/event.rs#L165