feat: move local signers to a separate crate, fix wasm #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
DaniPopes
force-pushed
the
dani/signer-wallet
branch
from
03f82dc to
3154b86
Compare
DaniPopes
force-pushed
the
dani/signer-wallet
branch
from
3154b86 to
c4a5737
Compare
onbjerg
reviewed
Mar 14, 2024
| use crate::{TransportError, TransportResult}; | ||
| use alloy_json_rpc::ResponsePacket; | ||
| /// Future for transport-level requests. | ||
| pub type TransportFut<'a, T = alloy_json_rpc::ResponsePacket, E = TransportError> = Pbf<'a, T, E>; |
There was a problem hiding this comment.
Wasming network as much as possible, it compiles now on wasm32-wasi or if getrandom.features = ["js"]
DaniPopes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262, but does not fix wasm for alloy-network. This is because
k256always importsgetrandomthrough multiple dependencies that userand_core.Closes #294
Fix wasm checks for most crates, see
wasm-wasiGHA job. This job should have the same results aswasm32-unknown-unknownwithgetrandom/js. Only crates that we cannot make compile is Trezor (libusb), GCP (idk), IPC (no fs)Closes #74