feat(providers): event, polling and streaming methods #274
Conversation
crates/providers/src/new.rs
Outdated
| /// | ||
| /// The return value depends on what stream `id` corresponds to. | ||
| /// See [`FilterChanges`] for all possible return values. | ||
| #[auto_impl(keep_default_for(&, &mut, Rc, Arc, Box))] |
There was a problem hiding this comment.
TIL this is necessary for dyn Provider to work, because otherwise auto_impl puts U: Provider + Sized bounds on the generic implementations if Self: Sized methods are not marked with keep_default_for. I added a test for this in this file
|
looks ossome |
crates/providers/src/new.rs
Outdated
| self.client().prepare("eth_getTransactionCount", (address, tag.unwrap_or_default())).await | ||
| } | ||
|
|
||
| /// Get a block by its number. | ||
| /// | ||
| /// TODO: Network associate | ||
| // TODO: Network associate |
There was a problem hiding this comment.
There is no network block RPC type, not really related to this PR
There was a problem hiding this comment.
Great!!! I am comfortable moving forward with this, let's get all the ethers examples ported now @yash-atreya @zerosnacks and please flag missing pieces to Dani as needed.
| /// .watch() | ||
| /// .await?; |
There was a problem hiding this comment.
OK I am fine with this API -- let's open issue for potentially auto-registering if possible, but we can move forward.
There was a problem hiding this comment.
Not sure what this means
| let t = self.transport() as &dyn std::any::Any; | ||
| t.downcast_ref::<PubSubFrontend>() | ||
| .or_else(|| { | ||
| t.downcast_ref::<BoxTransport>() | ||
| .and_then(|t| t.as_any().downcast_ref::<PubSubFrontend>()) | ||
| }) | ||
| .ok_or_else(TransportErrorKind::pubsub_unavailable) | ||
| } |
There was a problem hiding this comment.
we can probably improve this, but for now this seems fine
| /// let poller = provider.watch_blocks().await?; | ||
| /// let mut stream = poller.into_stream().flat_map(futures::stream::iter).take(5); | ||
| /// while let Some(block_hash) = stream.next().await { |
There was a problem hiding this comment.
Can we get rid of the into_stream().flat_map(futures::stream::iter)? When do we want to use the stream vs the iter? https://docs.rs/futures/latest/futures/stream/fn.iter.html
There was a problem hiding this comment.
flat_map(futures::stream::iter) is .flatten() for streams of vecs (turns the vec into a stream, then flattens it), as discussed eth_getFilterChanges returns a Vec when we poll it
with_provider) since we cannot return a value that references&Selfin theProvidertrait, see below feat(providers): event, polling and streaming methods #274 (comment)boxedto root provider and rpc clientswatch*,subscribe(TODO),filter*provider methods and related structsEventAPI from ethers, including event*filtermethods insol!(feat(sol-macro): add event filters to contracts core#563)subscribeandsubscribe_with_metahave been merged into one,watch, which is a flattened stream over theVec<Log>responses ofeth_getFilterChanges. The stream returns(E: SolEvent, Log)Arc::unwrap_or_cloneCloses #264
Ref #270 (no rename, but doc alias)
Closes #293