Fix typo and wrong value in default_factory for CalendarStream.calendars #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose it's exceedingly rare that a stream contain no calendars, but better safe than sorry
allenporter
approved these changes
Apr 27, 2024
|
(I realize you're saying in practice it was a typo and didn't even work, but agree fixing is way way better!) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 49 49
Lines 2952 2952
=======================================
Hits 2858 2858
Misses 94 94 ☔ View full report in Codecov by Sentry. |
|
Thank you @olejorgenb 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose it's exceedingly rare that a stream contain no calendars, but better safe than sorry