Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Todo due and dtstart validations #293

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Improve Todo due and dtstart validations #293

merged 6 commits into from
Feb 9, 2024

Conversation

allenporter
Copy link
Owner

@allenporter allenporter commented Feb 9, 2024 •
edited
Loading

Update validation rules to match https://www.rfc-editor.org/rfc/rfc5545#section-3.8.2.3

Description:  This property defines the date and time before which a
      to-do is expected to be completed.  For cases where this property
      is specified in a "VTODO" calendar component that also specifies a
      "DTSTART" property, the value type of this property MUST be the
      same as the "DTSTART" property, and the value of this property
      MUST be later in time than the value of the "DTSTART" property.
      Furthermore, this property MUST be specified as a date with local
      time if and only if the "DTSTART" property is also specified as a
      date with local time.

Copies some event date validation rules into todo component, and adds due specific rules. Adds a property to check when a Todo is due.

@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3564117) 96.72% compared to head (bb60869) 96.72%.

Files Patch % Lines
ical/todo.py 97.36% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files          49       49           
  Lines        2900     2935   +35     
=======================================
+ Hits         2805     2839   +34     
- Misses         95       96    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allenporter allenporter merged commit 93c69f9 into main Feb 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@allenporter