Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve uid when editing recurring events #286

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Conversation

allenporter
Copy link
Owner

@allenporter allenporter commented Feb 4, 2024

Copy the original uid to edited recurring event instances, such that instances of a recurring event are preserved. Share all the code for building recurring events.

#279

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e1e51af) 97.00% compared to head (2215196) 97.03%.

❗ Current head 2215196 differs from pull request most recent head 445a52c. Consider uploading reports for the commit 445a52c to get more accurate results

Files Patch % Lines
ical/recur_adapter.py 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   97.00%   97.03%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        2867     2899      +32     
==========================================
+ Hits         2781     2813      +32     
  Misses         86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Move todo list interface to TodoStore
- Combine recurrence adapters between todo list and timeline
- Simplify typing for sortable timespan items
- Move merge_and_expand_items to recur adapter
- Split edit and delete into separate functions
- Apply edits on all matching items
@allenporter allenporter merged commit dee0625 into main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant