Ralph2 vs Ralph3 cross validator #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurek
force-pushed
the
ng-verification-mechanism-mk-2
branch
from
6c6d41b to
de0872f
Compare
|
|
||
|
|
||
| def main(): | ||
| if 'cross_validator' not in os.environ.get('DJANGO_SETTINGS_MODULE', ''): |
There was a problem hiding this comment.
yes - it is correct (but not perfect). the idea here is to enable local settings easily (ex. ralph.cross_validator.settings_local).
MVP of data validator between ralph2 and ralph3. Currently it supports AssetModel and DataCenterAsset (partialy).
mkurek
force-pushed
the
ng-verification-mechanism-mk-2
branch
from
de0872f to
8e5b5e7
Compare
| return format_html('-') | ||
| html = '' | ||
| for item, values in obj.diff.items(): | ||
| print(item, values) |
There was a problem hiding this comment.
http://flake8.pycqa.org/en/latest/extensions.html#existing-extensions
maybe we should use anh of them, especially flake8-print?
|
🆗 |
|
🆗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVP of data validator between ralph2 and ralph3. Currently it supports AssetModel and DataCenterAsset (partialy).