Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added start/end gcode options, as well as toggling heated bed #45

Merged
merged 4 commits into from
Oct 23, 2021

Conversation

galamdring
Copy link
Contributor

#17
I added start and end gcode options, which can be entered on the command line.
Added tests to confirm, as well as manual command line testing.
I also added an option to toggle a heated bed, so that if you don't have a bed to heat, it won't add the bed heating start/end gcode.

GCode in options will override defaults, unless there is no temp commands. If those are missing (m104,m109,m140,m190) the corresponding commands will be added, unless ForceSafeStartStopGCode is set to false.

Start code expects {print_bed_temperature} and {print_temperature} to match cura startcode macros.

@aligator aligator added enhancement New feature or request feature labels Oct 19, 2021
@aligator aligator linked an issue Oct 19, 2021 that may be closed by this pull request
Copy link
Owner

@aligator aligator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution :-)

I have some change requests and suggestions for you to consider.

Have a nice day :-)

galamdring and others added 2 commits October 20, 2021 15:59
Co-authored-by: Johannes Hörmann <johannes.hoermann@t-online.de>
Copy link
Owner

@aligator aligator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now.

@aligator aligator merged commit 9f95ef7 into aligator:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configurable start and end gcode
2 participants