Improve goprofile plugin to support real local IP inclusion #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanLjp
changed the title
yyuuttaaoo
reviewed
Dec 25, 2023
There was a problem hiding this comment.
sidecar 模式设置采集本地地址，倒是采集上来的profile 数据都是127.0.0.1 追加一个本地真实ip 标签
EvanLjp
changed the title
yyuuttaaoo
changed the title
yyuuttaaoo
changed the title
yyuuttaaoo
approved these changes
Dec 29, 2023
yyuuttaaoo
pushed a commit
that referenced
this pull request
Jan 2, 2024
This commit addresses the limitation within the logtail profile schema regarding the inability to include the actual local IP address using the goprofile plugin. When profiling, the collection of non-specific host addresses (e.g., 127.0.0.1, localhost, or 0.0.0.0) leads to confusion over multiple target identification. To resolve this, the goprofile plugin has been enhanced to recognize and replace these generic addresses with the real local IP address of the machine. Changes include: Automatic substitution of custom label values that correspond to 127.0.0.1, localhost, or 0.0.0.0 with the machine's actual local IP address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the limitation within the logtail profile schema regarding the inability to include the actual local IP address using the goprofile plugin. When profiling, the collection of non-specific host addresses (e.g., 127.0.0.1, localhost, or 0.0.0.0) leads to confusion over multiple target identification. To resolve this, the goprofile plugin has been enhanced to recognize and replace these generic addresses with the real local IP address of the machine.
Changes include: