Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options command support complete options-name #612

Merged
merged 22 commits into from
Apr 2, 2019

Conversation

xuzhiyiYoh
Copy link
Contributor

Only complete options-name, other case use default complete.
Because options-value has different type, don't have a standard to complete.

Use case:
image

@xuzhiyiYoh
Copy link
Contributor Author

#611

@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #612 into master will decrease coverage by <.01%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #612      +/-   ##
=========================================
- Coverage    4.87%   4.86%   -0.01%     
=========================================
  Files         221     221              
  Lines       10964   10982      +18     
  Branches     1940    1944       +4     
=========================================
  Hits          534     534              
- Misses      10379   10397      +18     
  Partials       51      51
Impacted Files Coverage Δ
...bao/arthas/core/command/hidden/OptionsCommand.java 0% <0%> (ø) ⬆️
...has/core/command/klass100/SearchMethodCommand.java 0% <0%> (ø) ⬆️
...n/java/com/taobao/arthas/core/util/TokenUtils.java 86.66% <66.66%> (-9.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b265f5b...6339278. Read the comment docs.

@hengyunabc hengyunabc merged commit 1869964 into alibaba:master Apr 2, 2019
@hengyunabc
Copy link
Collaborator

Thank you very much.

@hengyunabc hengyunabc added this to the 3.1.1 milestone Apr 2, 2019
lzc-alioo pushed a commit to lzc-alioo/arthas that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants