Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Correct an off by one, and retry instead of fail with bad accounts #6217

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Jan 7, 2025

Summary

Test Plan

@jannotti jannotti self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.18%. Comparing base (df0613a) to head (416bb26).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
util/set.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6217      +/-   ##
==========================================
- Coverage   51.92%   48.18%   -3.74%     
==========================================
  Files         643      643              
  Lines       86240    86242       +2     
==========================================
- Hits        44779    41555    -3224     
- Misses      38596    41715    +3119     
- Partials     2865     2972     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannotti jannotti merged commit 45e94f5 into algorand:master Jan 8, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants