network: handle empty wsPeer supplied to transaction handler #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6195 +/- ##
==========================================
- Coverage 51.88% 51.86% -0.02%
==========================================
Files 639 639
Lines 85489 85495 +6
==========================================
- Hits 44359 44346 -13
- Misses 38320 38339 +19
Partials 2810 2810 ☔ View full report in Codecov by Sentry. |
cce
reviewed
Dec 10, 2024
cce
reviewed
Dec 10, 2024
gmalouf
reviewed
Dec 10, 2024
gmalouf
reviewed
Dec 10, 2024
gmalouf
reviewed
Dec 10, 2024
gossip or gossipSub |
gmalouf
previously approved these changes
Dec 11, 2024
cce
reviewed
Dec 12, 2024
cce
reviewed
Dec 12, 2024
cce
previously approved these changes
Dec 12, 2024
algorandskiy
force-pushed
the
pavel/txhandler-nil-wsp2
branch
from
bf4c30c to
388dbc8
Compare
gmalouf
approved these changes
Dec 19, 2024
cce
approved these changes
Dec 20, 2024
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a race between pubsub new peer discovery and wsPeer registration:
{"time":"2024-12-04T16:42:43.237595Z","log":"[signal SIGSEGV: segmentation violation code=0x1 addr=0xa0 pc=0x1a46d72]"} {"time":"2024-12-04T16:42:43.237610Z","log":"goroutine 1012678170 [running]:"} {"time":"2024-12-04T16:42:43.237617Z","log":"github.com/algorand/go-algorand/network.(*wsPeer).RoutingAddr(0xc02a57b588?)"} {"time":"2024-12-04T16:42:43.237623Z","log":"\tgithub.com/algorand/go-algorand/network/wsPeer.go:387 +0x12"} {"time":"2024-12-04T16:42:43.237628Z","log":"github.com/algorand/go-algorand/data.(*TxHandler).incomingTxGroupAppRateLimit(0xc0000fec60, {0xc0b02a6008, 0x1, 0x2}, {0x2c51360, 0x0})"} {"time":"2024-12-04T16:42:43.237634Z","log":"\tgithub.com/algorand/go-algorand/data/txHandler.go:722 +0xcd"}Suggested fix is to use
gsPeertemporary type good enough for tx handler.Additional fixes:
Test Plan
Added a test confirming
txTopicValidatordoes not call tx handler with an empty wsPeer.