p2p: reuse existing libp2p.Host for http clients #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6129 +/- ##
==========================================
+ Coverage 54.28% 56.17% +1.88%
==========================================
Files 494 494
Lines 69936 69951 +15
==========================================
+ Hits 37968 39297 +1329
+ Misses 29246 27981 -1265
+ Partials 2722 2673 -49 ☔ View full report in Codecov by Sentry. |
algorandskiy
force-pushed
the
pavel/p2p-get-peer-host
branch
from
1061d11 to
13f21a9
Compare
cce
reviewed
Sep 13, 2024
cce
previously approved these changes
Sep 13, 2024
gmalouf
reviewed
Sep 13, 2024
gmalouf
previously approved these changes
Sep 13, 2024
gmalouf
approved these changes
Sep 13, 2024
cce
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some scenarios
GetPeersfor archival role gets called too often, and each time new libp2p.Host gets created that causes high memory usage.Although this fix is good as is, the underlying issue with high
GetPeersinvocation rate is under investigation.Test Plan
Tested manually against devnet.