p2p: fix connection deduplication in hybrid mode #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
force-pushed
the
pavel/p2p-hybrid-dedup-fix
branch
from
18f228b to
1d4dabd
Compare
algorandskiy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6082 +/- ##
=======================================
Coverage 56.27% 56.27%
=======================================
Files 488 488
Lines 69587 69588 +1
=======================================
+ Hits 39157 39161 +4
+ Misses 27771 27769 -2
+ Partials 2659 2658 -1 ☔ View full report in Codecov by Sentry. |
cce
reviewed
Jul 26, 2024
cce
approved these changes
Jul 26, 2024
jasonpaulos
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some TestHybridNetwork_DuplicateConn failures indicate deduplication does not work when a node first connects via wsnet and then via p2p. In this case p2p correctly determines duplicate but does not exit the handler as it should.
Test Plan
Added a unit test checking the stream handler processes duplication correctly.