Config: Expose merged configuration for easier debugging #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… private/admin API.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6049 +/- ##
==========================================
+ Coverage 56.13% 56.15% +0.02%
==========================================
Files 488 488
Lines 69425 69432 +7
==========================================
+ Hits 38973 38991 +18
+ Misses 27796 27787 -9
+ Partials 2656 2654 -2 ☔ View full report in Codecov by Sentry. |
gmalouf
changed the title
algorandskiy
approved these changes
Jul 3, 2024
cce
reviewed
Jul 3, 2024
cce
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR also introduces endpoint to retrieve local config in json format, scoped to private/admin API. It additionally adds a print to the algo-out file at startup of a fully hydrated/merged version of the configuration.
Test Plan
Added test for the new
GetConfigendpoint.