tests: preserve logs on LibGoalFixture failure #6030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmalouf
reviewed
Jun 13, 2024
gmalouf
reviewed
Jun 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6030 +/- ##
==========================================
+ Coverage 55.86% 55.89% +0.03%
==========================================
Files 482 482
Lines 68475 68508 +33
==========================================
+ Hits 38253 38294 +41
+ Misses 27620 27616 -4
+ Partials 2602 2598 -4 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Gary Malouf <982483+gmalouf@users.noreply.github.com>
gmalouf
approved these changes
Jun 13, 2024
cce
changed the title
cce
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With extra logging the most recent failure showed node cannot stop properly but by the time of detecting this all data dirs (and logs) are gone since the test itself competed OK.
This PR propagates facts about how a node was terminated (term vs kill) so LibGoalFuxture can know it and preserve node.log for future analysis.
Also added debugging logs into
node.Stopsince it appears to be blocked by some service, and corrected missing new lines in LibGoalFixture stderr logging.Test Plan
Tested manually: made algod not reacting to SIGTERM, node controller used SIGKILL. This was logged and data dirs with logs remained preserved.