build: add universal Mac make target #6023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6023 +/- ##
==========================================
- Coverage 55.90% 55.85% -0.05%
==========================================
Files 482 482
Lines 68436 68436
==========================================
- Hits 38258 38225 -33
- Misses 27583 27612 +29
- Partials 2595 2599 +4 ☔ View full report in Codecov by Sentry. |
ohill
commented
Jun 10, 2024
cce
previously approved these changes
Jun 13, 2024
onetechnical
previously approved these changes
Jun 21, 2024
gmalouf
previously approved these changes
Jun 25, 2024
onetechnical
previously approved these changes
Jun 25, 2024
algorandskiy
previously approved these changes
Jun 25, 2024
cce
previously approved these changes
Jun 26, 2024
ohill
dismissed stale reviews from cce, algorandskiy, onetechnical, and gmalouf
via
217750e
gmalouf
approved these changes
Jun 26, 2024
cce
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new
universalbuild target that builds two libsodium libraries, runs themake buildtarget for two architectures, and then uses lipo to merge the binaries for amd64 and arm64 together.Test Plan
Not sure what is next, or how this would integrate into the release process. The universal binaries are roughly twice the size, but if that's a problem, the build target produces 3 bin directories (bin-darwin-amd64, bin-darwin-arm64, bin-darwin-universal) allowing for different release options.