agreement: log current player state for VoteBroadcast and ProposalBroadcast events #6007
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6007 +/- ##
==========================================
- Coverage 55.94% 55.91% -0.04%
==========================================
Files 482 482
Lines 68310 68315 +5
==========================================
- Hits 38219 38201 -18
- Misses 27500 27513 +13
- Partials 2591 2601 +10 ☔ View full report in Codecov by Sentry. |
| @@ -422,6 +422,9 @@ func (t pseudonodeVotesTask) execute(verifier *AsyncVoteVerifier, quit chan stru | |||
| Type: logspec.VoteBroadcast, | |||
| Sender: vote.R.Sender.String(), | |||
| Hash: vote.R.Proposal.BlockDigest.String(), | |||
| Round: uint64(t.round), | |||
| Period: uint64(t.period), | |||
| Step: uint64(t.step), | |||
There was a problem hiding this comment.
I think t.round, t.period, and t.step are the same as vote.R.Round, vote.R.Period, and vote.R.Step here. the t is the task of making these votes, and a few lines above task.execute() calls t.node.makeVotes(t.round, t.period, t.step, t.prop, t.participation) to make these votes, leading to the vote.R.Round, etc being assigned..
if you want to get the player's own current step, that does not look to be accessible from inside pseudonodeVotesTask.execute. This task is made whenever you see lines in player making this action pseudonodeAction{T: attest, Round: p.Round, Period: p.Period, Step: cert, Proposal: e.Proposal} but the step for the vote to be made is not always the same as the current value of player.step.
Summary
While debugging some delayed consensus on network startup I noticed
VoteBroadcastandProposalBroadcastdo not log player state like other events ({Vote|Proposal}Accepted, VoteAttest, ProposalAccepted etc do).This PR adds player's Round, Period, Step logging for these events.
Test Plan
Local run