CICD: Update to switch e2e_expect to large #6004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetechnical
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6004 +/- ##
==========================================
+ Coverage 55.86% 55.89% +0.03%
==========================================
Files 481 481
Lines 68357 68357
==========================================
+ Hits 38185 38209 +24
+ Misses 27568 27554 -14
+ Partials 2604 2594 -10 ☔ View full report in Codecov by Sentry. |
gmalouf
previously approved these changes
May 28, 2024
gmalouf
approved these changes
May 28, 2024
jasonpaulos
approved these changes
May 30, 2024
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We occasionally see memory issues with e2e tests, so let's switch from medium (2 CPU, 7.5 GB) to large (4 CPU, 15 GB). This is at the cost of more credits usage, obviously. This is for e2e_expect and e2e_expect_nightly.
Unrelated: also remove CODEOWNERS file, which is deprecated.
Test Plan
See if nightlies succeed.